Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading indication for content composers #1613

Merged
merged 4 commits into from
Sep 5, 2019
Merged

Loading indication for content composers #1613

merged 4 commits into from
Sep 5, 2019

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Sep 5, 2019 •
edited
Loading

Checklist:

@swaterkamp swaterkamp changed the base branch from master to gsa-8.0 September 5, 2019 13:23
@swaterkamp swaterkamp self-assigned this Sep 5, 2019
@swaterkamp swaterkamp marked this pull request as ready for review September 5, 2019 13:35
@swaterkamp swaterkamp requested a review from a team September 5, 2019 13:35
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #1613 into gsa-8.0 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           gsa-8.0    #1613   +/-   ##
========================================
  Coverage    37.39%   37.39%           
========================================
  Files          966      966           
  Lines        22087    22087           
  Branches      6208     6208           
========================================
  Hits          8259     8259           
  Misses       12501    12501           
  Partials      1327     1327
Impacted Files Coverage Δ
gsa/src/web/components/dialog/twobuttonfooter.js 100% <ø> (ø) ⬆️
gsa/src/web/pages/reports/alertactions.js 6.55% <0%> (ø) ⬆️
gsa/src/web/pages/reports/detailspage.js 3.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f69be...a62a2fd. Read the comment docs.

@bjoernricks bjoernricks merged commit 783b777 into greenbone:gsa-8.0 Sep 5, 2019
@swaterkamp swaterkamp deleted the LoadingIndicatorButton branch February 20, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees

@swaterkamp swaterkamp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swaterkamp @bjoernricks